fix(generate): correct component path when module is generated in subfolder, and parent folder is not a module too #3916
Conversation
Meligy
force-pushed
the
fix/module-component-subfolder-non-module
branch
2 times, most recently
from
e9da693 to
b4e3266
Compare
Meligy
force-pushed
the
fix/module-component-subfolder-non-module
branch
from
b4e3266 to
4369fd2
Compare
|
Could you also add an e2e test? Acceptance tests are good but likely to be removed after 1.0 but e2e will remain. |
Meligy
force-pushed
the
fix/module-component-subfolder-non-module
branch
from
4369fd2 to
4bd2bc6
Compare
|
@hansl Added e2e test |
Meligy
force-pushed
the
fix/module-component-subfolder-non-module
branch
3 times, most recently
from
00e79c5 to
ccfaf9d
Compare
|
e2e test is passing now. |
|
LGTM. Need @Brocco's approval. |
| // as `this.dynamicPath.dir` will be the same as `this.dynamicPath.appRoot` | ||
| // 2. If it does have `/` (like `parent/mod-name`), it'll be `/parent/mod-name/mod-name` | ||
| // as `this.dynamicPath.dir` minus `this.dynamicPath.appRoot` will be `/parent` | ||
| var dmouleDir = |
There was a problem hiding this comment.
typo? rename please.
dmouleDir -> moduleDir
Also, please rebase and then it can be merged.
…folder, and parent folder is not a module too fixes angular#3255
Meligy
force-pushed
the
fix/module-component-subfolder-non-module
branch
from
ccfaf9d to
512d53a
Compare
|
Can we mark this for merge now? Cheers, |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
…folder, and parent folder is not a module too (angular#3916) fixes angular#3255
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #3255
Another attempt at using the correct component name / path when generating modules, that takes care of the special case in #3255.
Existing behaviour that this PR fixes
if you
ng g module parent --routing, you canng g module parent/child --routing.But if
src/app/parentis just a normal folder, the component generation forng g module parent/childfails.To test the PR:
ng g module normal-case --routingto ensure basic scenario is not brokenng g module parentandng g module parent/child --routingto ensure this scenario is not broken toomkdir src/app/parent-folder, and thenng g module parent-folder/child-module --routingto test that this PR does what it promises to doOr alternatively look at the provided tests in the PR and existing tests, and ensure they cover all above scenarios, and are passing in CI.
Note
This is maybe the 3rd or so attempt at getting this path to work in all scenarios. We are protected by tests though, and we keep adding more tests the more scenarios we get. Let's see if this becomes the last change of this path/name.